fix(nospace): don't move to next word when removing last character (@Leonabcd123)#8038
Merged
Miodec merged 3 commits intoJun 2, 2026
Merged
Conversation
github-actions
Bot
added
the
waiting for review
Member
|
Is the reorder necessary? |
Miodec
added
waiting for update
Contributor
Author
Yes, monkeytype/frontend/src/ts/input/handlers/insert-text.ts Lines 181 to 183 in 3462738 Could be skipped when shouldGoToNextWord = true and removeLastChar = true, even though we aren't moving to the next word, so it should run.
|
github-actions
Bot
removed
the
waiting for update
|
Thanks for fixing this so rapidly. Your contribution is greatly appreciated ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8037
Not sure whether
stop on error = wordshould have any effect whennospaceis enabled, so this pr currently only fixes the case where a mistake isn't blocked at the end of a word innospace.